readFile in promises very slow
Open
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 399
- Forks
- 11
- Avg merge
- 29m
- Merged PRs (30d)
- 1
Description
Version
v21.7.1
Platform
Darwin evgeniis.local 23.4.0 Darwin Kernel Version 23.4.0: Wed Feb 21 21:44:43 PST 2024; root:xnu-10063.101.15~2/RELEASE_ARM64_T6000 arm64
Subsystem
No response
What steps will reproduce the bug?
slow
const fs = require('fs/promises');
const start = Date.now();
let count = 0;
for (let i = 0; i < 10000; i++) {
fs.readFile("./text.txt", { encoding: 'utf-8' })
.then((data) => {
if (data !== "Hello, world") throw 1;
count++
if (count === 10000) {
console.log('time: ', Date.now() - start);
}
})
.catch((err) => {
throw 1
})
}
fast
const fs = require('fs');
const util = require('util');
const readFile = util.promisify(fs.readFile);
const start = Date.now();
let count = 0;
for (let i = 0; i < 10000; i++) {
readFile("./text.txt", { encoding: 'utf-8' })
.then((data) => {
if (data !== "Hello, world") throw 1;
count++
if (count === 10000) {
console.log('time: ', Date.now() - start);
}
})
.catch((err) => {
throw 1
})
}
How often does it reproduce? Is there a required condition?
No response
What is the expected behavior? Why is that the expected behavior?
No response
What do you see instead?
The promise version is 2 times slower. My tests showed 200ms vs 100ms
Additional information
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running the two provided benchmarks on Node.js v21.7.1 and comparing fs/promises.readFile with util.promisify(fs.readFile). Investigate the performance difference using the fs/promises and fs entry points mentioned in the report; done requires a reproducible explanation and a confirmed expected behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- performance
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100