nodejs / nodejs/performance

Remove double buffer in http.IncomingMessage

Open
#148 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Shell
Stars
399
Forks
11
Avg merge
29m
Merged PRs (30d)
1

Description

http.IncomingMessage is an instance of Readable, which does buffering. However the data is coming from a socket, which also does buffering. If we could remove the Readable buffering, we could remove quite a bit of overhead.

This might be too breaking.

#147

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing issue #147 and the implementation of http.IncomingMessage, Readable, and the socket buffering involved. Determine whether removing Readable buffering is feasible without an unacceptable breaking change; done means the overhead is reduced and the compatibility impact is resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js
Domain
backend, performance
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.