diagnostics_channel: Channel::binding_data_ dangles after environment cleanup, crashing node:sqlite at exit
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 122k
- Forks
- 37.3k
- Avg merge
- 4d 2h
- Merged PRs (30d)
- 283
Description
Version
v27.0.0-pre (2dfdb6a4206)
Platform
Darwin 25.6.0 arm64
Subsystem
diagnostics_channel, sqlite
What steps will reproduce the bug?
Channel holds its BindingData as a raw pointer that is never cleared, so any native holder that outlives environment cleanup reads a destroyed object. Here's a replication case using node:sqlite:
const dc = require('node:diagnostics_channel');
const { DatabaseSync } = require('node:sqlite');
dc.subscribe('sqlite.db.query', () => {});
const db = new DatabaseSync(':memory:');
db.exec('CREATE TABLE t(x)');
const ins = db.prepare('INSERT INTO t VALUES (?)');
for (let i = 0; i < 200; i++) ins.run(i);
// Start iterating and abandon it: the statement stays mid-step, so the
// finalize that happens at teardown fires SQLite's profile callback.
const it = db.prepare('SELECT * FROM t').iterate();
it.next();
globalThis.keepAlive = { db, it };
console.log('reached end of script');
How often does it reproduce? Is there a required condition?
Three conditions are required (all included in the example above):
- A subscriber on
sqlite.db.query, so the SQLite profile hook is installed. - A statement left mid-step at exit, so that the finalize during teardown has a started statement to profile.
- No explicit
close(), so the statement is finalized by the destructor chain afterEnvironment::RunCleanup()rather than before it.
What is the expected behavior? Why is that the expected behavior?
Exiting a process that used node:sqlite with a sqlite.db.query subscriber
shouldn't crash.
What do you see instead?
SIGSEGV, exit 139, after the script has finished.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Run the provided node:diagnostics_channel and node:sqlite reproduction first, then trace Channel::binding_data_ through Environment::RunCleanup() and the SQLite profile callback. Confirm the fix against the same exit scenario, including a statement left mid-step without explicit close(), and ensure the process exits without SIGSEGV.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js, sqlite
- Domain
- backend, databases, observability
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100