wasm: streaming APIs accept non-Uint8Array response body chunks
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 122k
- Forks
- 37.3k
- Avg merge
- 4d 2h
- Merged PRs (30d)
- 283
Description
Version
latest main branch
Platform
7.1.3-arch1-3
Subsystem
wasm
What steps will reproduce the bug?
const bytes = new Uint8Array([
0x00, 0x61, 0x73, 0x6d, // \0asm
0x01, 0x00, 0x00, 0x00, // version 1
]);
const stream = new ReadableStream({
start(controller) {
controller.enqueue(bytes.buffer); // ArrayBuffer, not Uint8Array
controller.close();
},
});
const response = new Response(stream, {
headers: {
'Content-Type': 'application/wasm',
},
});
WebAssembly.compileStreaming(response).then(
() => console.log('unexpectedly compiled'),
(error) => console.error('rejected:', error),
);
How often does it reproduce? Is there a required condition?
Every
What is the expected behavior? Why is that the expected behavior?
Fetch body consumption requires every chunk read from the response body to be a Uint8Array. Other values, including ArrayBuffer, DataView, and other typed arrays, should cause the operation to reject with a TypeError.
What do you see instead?
WebAssembly.compileStreaming() and WebAssembly.instantiateStreaming() accept response bodies whose
ReadableStream produces non-Uint8Array chunks.The WebAssembly module is compiled successfully, even though the response body produces an ArrayBuffer chunk.
Additional information
Refs: https://github.com/web-platform-tests/wpt/blob/master/wasm/webapi/wasm_stream_compile_test.any.js#L80-L93
Refs: https://github.com/web-platform-tests/wpt/blob/master/wasm/webapi/wasm_stream_instantiate_test.any.js#L79-L92
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the WebAssembly.compileStreaming() and WebAssembly.instantiateStreaming() entry points and the referenced WPT tests, wasm/webapi/wasm_stream_compile_test.any.js and wasm/webapi/wasm_stream_instantiate_test.any.js. Reproduce the ArrayBuffer-chunk case from the report, then verify that non-Uint8Array response chunks reject with a TypeError while valid chunks continue to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, wasm
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100