nodejs / nodejs/node

26.0.0 fails to build on NetBSD: missing include

Open Beginner friendly
#63,146 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

arm build v8 engine
Dominant language
JavaScript
Stars
122k
Forks
37.3k
Avg merge
4d 2h
Merged PRs (30d)
283

Description

Version

26.0.0

Platform
NetBSD virtual 11.99.6 NetBSD 11.99.6 (GENERIC64) #0: Mon May  4 09:49:31 CEST 2026
Subsystem

No response

What steps will reproduce the bug?

Build NodeJS 26.0.0 on NetBSD

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior? Why is that the expected behavior?

Build proceeds

What do you see instead?

Build fails with:

../deps/v8/src/base/memcopy.h: In function 'void v8::base::SimdMemCopy(void*, const void*, size_t)':
../deps/v8/src/base/memcopy.h:57:23: error: 'CHAR_BIT' was not declared in this scope
   57 |       sizeof(count) * CHAR_BIT - bits::CountLeadingZeros(count - 1);
      |                       ^~~~~~~~
../deps/v8/src/base/memcopy.h:21:1: note: 'CHAR_BIT' is defined in header '<climits>'; this is probably fixable by adding '#include <climits>'
Additional information

Fix:

--- deps/v8/src/base/memcopy.h.orig	2026-05-06 07:22:58.678410124 +0000
+++ deps/v8/src/base/memcopy.h
@@ -5,6 +5,7 @@
 #ifndef V8_BASE_MEMCOPY_H_
 #define V8_BASE_MEMCOPY_H_
 
+#include <climits>
 #include <stdlib.h>
 
 #include <atomic>

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with deps/v8/src/base/memcopy.h, where the NetBSD build reports that CHAR_BIT is undeclared. Reproduce the Node.js 26.0.0 build on NetBSD, verify the header declaration is available there, and confirm the build proceeds successfully after the focused change.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js
Domain
build-system, operating-systems
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
85/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.