`replServer.setupHistory()` silently discards callback errors since v24.2.0
Open
Nobody has claimed this yet.
repl
stale
- Dominant language
- JavaScript
- Stars
- 122k
- Forks
- 37.3k
- Avg merge
- 4d 2h
- Merged PRs (30d)
- 283
Description
Version
26.0.0-pre
Platform
Linux ubuntu 6.8.0-87-generic #88-Ubuntu SMP PREEMPT_DYNAMIC Sat Oct 11 09:28:41 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Microsoft Windows NT 10.0.26200.0 x64
Subsystem
No response
What steps will reproduce the bug?
- Add an intentional bad assert in the file of test case: test\parallel\test-repl-history-perm.js
- Run python tools/test.py --mode=release parallel
- It reported "All tests passed."
How often does it reproduce? Is there a required condition?
I can reproduce it everytime
What is the expected behavior? Why is that the expected behavior?
Test failed as 1 not equal 2 obviously.
What do you see instead?
[00:51]% 100|+ 3953|- 0]: Done
All tests passed.
Additional information
I try several versions of node. It seemed to happen from v24.2.0.
This is screenshot of v24.1.0
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with test/parallel/test-repl-history-perm.js and reproduce the issue using python tools/test.py --mode=release parallel. Compare the behavior between v24.1.0 and v24.2.0, focusing on why the intentional assertion does not fail the test run. Done means callback errors from replServer.setupHistory() cause the test command to report failure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100