nodejs / nodejs/node

[Proposal] Enabling `no-param-reassign` eslint rule

Open
#55,566 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

never-stale
Dominant language
JavaScript
Stars
122k
Forks
37.3k
Avg merge
4d 2h
Merged PRs (30d)
283

Description

I've personally often feel frustrated due to being extremely hard to track an implementation after a reassignment of parameters, due to the ambiguity of types in a function that has a JSDoc declaration.

I recommend enabling https://eslint.org/docs/latest/rules/no-param-reassign. There is currently ✖ 1597 problems (1597 errors, 0 warnings).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the proposed ESLint no-param-reassign rule and running the repository's existing ESLint checks. The current lint run reports 1,597 errors; done means the rule is enabled and those parameter-reassignment violations are resolved without introducing new lint errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.