nodejs / nodejs/node

Commit queue overwrites commit author

Open
#52,967 7 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

confirmed-bug meta
Dominant language
JavaScript
Stars
122k
Forks
37.3k
Avg merge
4d 2h
Merged PRs (30d)
283

Description

See https://github.com/nodejs/node/pull/52745 and https://github.com/nodejs/node/pull/52860 (@marco-ippolito)

When the commit author and the PR author do not match, the original commit author is lost when the PR is merged.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading PRs 52745 and 52860, then trace the commit-queue flow involved when the commit author differs from the PR author. Reproduce that merge scenario and verify that the original commit author is preserved after the PR is merged.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.