Source maps test failure

Open Beginner friendly
#313 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
javascript, node.js
Domain
testing

Research direction

Start with test/parallel/test-node-output-sourcemaps.mjs:29 and the source-map/output/source_map_throw_class.js fixture named in the failure. Compare the expected snapshot with the actual stack output, then run the reported test command. Done means the source-map test passes with the intended class-method stack name.

Written by the indexing model from the issue text.

Description

[09](https://github.com/nodejs/node-v8/actions/runs/27495416036/job/81268444074#step:9:1310)
Path: parallel/test-node-output-sourcemaps
Error: --- stdout ---
Test failure: 'source-map/output/source_map_throw_class_method.js'
Location: test/parallel/test-node-output-sourcemaps.mjs:29:5
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected

  'Error: This is a test\n' +
    '    at Foo.bar (<project-root>/test/fixtures/source-map/throw-class-method.js:3:11)\n' +
    '    at Object.<anonymous> (<project-root>/test/fixtures/source-map/throw-class-method.js:12:7)\n' +
    'Error: This is a test\n' +
+   '    at Object.bar (<project-root>/test/fixtures/source-map/throw-class-method.js:3:11)\n' +
-   '    at Bar.bar (<project-root>/test/fixtures/source-map/throw-class-method.js:3:11)\n' +
    '    at Object.<anonymous> (<project-root>/test/fixtures/source-map/throw-class-method.js:19:7)\n'

    at assertSnapshot (/home/runner/work/node-v8/node-v8/node/test/common/assertSnapshot.js:173:12)
    at async Module.spawnAndAssert (/home/runner/work/node-v8/node-v8/node/test/common/assertSnapshot.js:208:3)
    at async TestContext.<anonymous> (file:///home/runner/work/node-v8/node-v8/node/test/parallel/test-node-output-sourcemaps.mjs:30:7)
    at async Test.run (node:internal/test_runner/test:1389:7)
    at async Suite.processPendingSubtests (node:internal/test_runner/test:960:7) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 'Error: This is a test\n' +
    '    at Foo.bar (<project-root>/test/fixtures/source-map/throw-class-method.js:3:11)\n' +
    '    at Object.<anonymous> (<project-root>/test/fixtures/source-map/throw-class-method.js:12:7)\n' +
    'Error: This is a test\n' +
    '    at Object.bar (<project-root>/test/fixtures/source-map/throw-class-method.js:3:11)\n' +
    '    at Object.<anonymous> (<project-root>/test/fixtures/source-map/throw-class-method.js:19:7)\n',
  expected: 'Error: This is a test\n' +
    '    at Foo.bar (<project-root>/test/fixtures/source-map/throw-class-method.js:3:11)\n' +
    '    at Object.<anonymous> (<project-root>/test/fixtures/source-map/throw-class-method.js:12:7)\n' +
    'Error: This is a test\n' +
    '    at Bar.bar (<project-root>/test/fixtures/source-map/throw-class-method.js:3:11)\n' +
    '    at Object.<anonymous> (<project-root>/test/fixtures/source-map/throw-class-method.js:19:7)\n',
  operator: 'strictEqual',
  diff: 'simple'
}
Command: out/Release/node --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /home/runner/work/node-v8/node-v8/node/test/parallel/test-node-output-sourcemaps.mjs

===
=== 1 tests failed
===

Failed tests:
out/Release/node --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /home/runner/work/node-v8/node-v8/node/test/parallel/test-node-output-sourcemaps.mjs
Dominant language
Shell
Stars
466
Forks
75
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nodejs/node-v8

All issues in nodejs/node-v8

Similar issues

More Shell/Bash issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.