Why is `package-lock.json` ignored?
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 10.7k
- Forks
- 1.9k
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 5
Description
This was first brought up in a review. A couple people mentioned this. No action was taken.
Why is package-lock.json ignored? https://github.com/nodejs/node-gyp/blob/main/.gitignore#L7
The general consensus seems to bee that it should be committed. If there is a reason it shouldn't, it should probably be listed alongside the ignore (as a comment).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting .gitignore at line 7 and the linked node-gyp pull request review. Determine why package-lock.json is ignored and whether the repository's intended policy is documented elsewhere. Done means either documenting the reason beside the ignore rule or clarifying the repository change needed if no reason exists.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- node.js
- Domain
- build-system, tooling
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100