nodejs / nodejs/node-gyp

Duplicate elimination makes it impossible to include multiple frameworks on macOS

Open
#2,844 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
10.7k
Forks
1.9k
Avg merge
1d 4h
Merged PRs (30d)
5

Description

  • Node Version: node-gyp 9.3.1
  • Platform: Darwin 20.6.0
  • Compiler: n/a

binding.gyp:

{
  'targets': [{
    'target_name': 'test',
    'libraries': [ '-framework', 'CoreGraphics', '-framework', 'CoreText' ]
  }]
}
node-gyp configure

Resulting test.target.mk:

...
LIBS := \
	-framework \
	CoreGraphics \
	CoreText
...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the binding.gyp example and run node-gyp configure to inspect the generated test.target.mk output. Trace the duplicate-elimination step involved in framework libraries; done means multiple macOS frameworks remain independently represented in the generated linker flags.

Written by the indexing model from the issue text.

Assessment

Tech stack
macos, node.js, python
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.