The `VCCLCompilerTool.floatingPointModel` setting is not recognized.
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 10.7k
- Forks
- 1.9k
- Avg merge
- 1d 4h
- Merged PRs (30d)
- 5
Description
Environment
Version
node-gyp 9.3.0
binding.gyp
"msvs_settings": {
"VCCLCompilerTool": {
"floatingPointModel": 2, # /fp:fast
}
}
Output
Warning: unrecognized setting VCCLCompilerTool/floatingPointModel while converting to MSBuild.
Bug
MSVSSettings.ValidateMSVSSettings does not recognize the VCCLCompilerTool.floatingPointModel setting and tries to validate VCCLCompilerTool.FloatingPointModel, when in fact, there’s no such thing as VCCLCompilerTool.FloatingPointModel but VCCLCompilerTool.floatingPointModel.
I know, of all properties of VCCLCompilerTool that start with a capital letter, this oddly starts with a lowercase letter. But look; it is:
VCCLCompilerTool.floatingPointModelPropertySets or gets the floating point model.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at MSVSSettings.ValidateMSVSSettings and trace how VCCLCompilerTool properties are normalized and validated. Update recognition of the documented floatingPointModel setting so the reported MSBuild conversion warning is gone, then verify the binding.gyp example converts without that warning.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100