nodejs / nodejs/node-core-utils
validate commits to deps/v8
Open
Nobody has claimed this yet.
feature request
- Dominant language
- JavaScript
- Stars
- 314
- Forks
- 137
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 24
Description
We have a few rules about commits to our V8 copy, that are documented in the maintaining V8 guide.
Some things could be easy to check:
- For backports / cherry-picks
- Format of the commit title
- Presence / correctness of the original commit message in the message
- Presence of the
Refs: github_urlin the message - Has the embedder string been incremented?
- For regular (minor or major) updates
- Format of the commit title
Those are just a few ideas. Let me know if it makes sense to implement them here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading doc/guides/maintaining-V8.md and identify the existing commit-validation entry point in node-core-utils. Define which backport and regular-update checks are in scope, then verify that each selected rule reports invalid commits and accepts valid ones.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- cli, tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100