nodejs / nodejs/node-core-utils
Branch protection improvements
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 314
- Forks
- 137
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 24
Description
FYI I just created a ruleset for this repo: https://github.com/nodejs/node-core-utils/settings/rules/4654889
It targets the default branch and enables:
- Restrict deletions
- Require linear history
- Require a pull request with at least one approval
- Block force pushes
Only the pull request requirements are new compared to the old branch protection rule (https://github.com/nodejs/node-core-utils/settings/branch_protection_rules/17880641)
I think we can delete that rule. The only thing that remains in it is the restriction of who can push and that only restricts the nodejs-github-bot account. I don't think there's a convenient way to port that to rulesets. We could use the bypass list but then every pull request would always be red and require collaborators to click the bypass checkbox.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the ruleset at the linked GitHub repository settings page and compare it with the existing branch protection rule. Confirm whether the old rule's nodejs-github-bot push restriction can be replaced or removed without disrupting pull requests. Done means the repository has the intended single branch-protection configuration.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github
- Domain
- devops
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100