nodejs / nodejs/node-core-utils
git node land fails with mismatched commits
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 314
- Forks
- 137
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 24
Description
Landing 54990 fails with a new error that I've never seen before.
❯ git node land 54990
✔ Done loading data for nodejs/node/pull/54990
----------------------------------- PR info ------------------------------------
Title src: replace splitstring with built-in (#54990)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch anonrig:replace-stringviewsplit -> nodejs:main
Labels c++, lib / src, needs-ci, commit-queue-failed, dont-land-on-v18.x, dont-land-on-v20.x
Commits 1
- src: replace splitstring with built-in
Committers 1
- Yagiz Nizipli <yagiz@cloudflare.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/54990
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Wed, 18 Sep 2024 01:10:06 GMT
✔ Approvals: 5
✔ - Daniel Lemire (@lemire): https://github.com/nodejs/node/pull/54990#pullrequestreview-2312621536
✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/54990#pullrequestreview-2317889526
✔ - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/54990#pullrequestreview-2317895154
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54990#pullrequestreview-2319866121
✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/54990#pullrequestreview-2572079210
✘ Last GitHub CI failed
ℹ Last Full PR CI on 2025-02-09T19:27:37Z: https://ci.nodejs.org/job/node-test-pull-request/65094/
⠋ Querying data for job/node-test-pull-request/65094/ ✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ This PR is not ready to land, do you want to continue? Yes
⠙ Querying API for job/node-test-pull-request/65094/ ✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
✔ Do you want to try reset the local main branch to upstream/main? No
⠼ Downloading patch for 54990From https://github.com/nodejs/node
* branch refs/pull/54990/merge -> FETCH_HEAD
✔ Fetched commits as 03e9adf876e2..6511d48523cb
--------------------------------------------------------------------------------
✘ Mismatched commits:
Unexpected commit 6511d48523cb02b9323a810ff0ea25d55a9665ac
Missing commit d9790fef541096f4c7a8d869a21440e318117964
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the git node land command and reproduce the reported behavior using PR 54990 and its fetched commits. Trace why the command reports an unexpected commit and a missing commit; done means the mismatch is correctly handled and the command's result is verified against the PR data.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, github, javascript
- Domain
- cli, devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100