nodejs / nodejs/node-core-utils

git node land just hangs

Open
#599 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
314
Forks
137
Avg merge
2d 8h
Merged PRs (30d)
24

Description

I am unable to land PRs since a few months ago. I've tried issuing new credentials as well as different PRs. This happens for me on every PR.

Logs & Details

Kapture 2021-12-17 at 10 52 04-min

NCU_VERBOSITY=debug git node land 41170

[DEBUG] [SpawnSync] git config --get remote.upstream.url { cwd: '/Users/panva/repo/node' }

[DEBUG] [SpawnSync] git rev-parse --abbrev-ref HEAD { cwd: '/Users/panva/repo/node' }

[DEBUG] [SpawnSync] git rev-parse --abbrev-ref HEAD { cwd: '/Users/panva/repo/node' }

[DEBUG] [fetch] https://api.github.com/graphql

[DEBUG] [SpawnSync] git config --get remote.upstream.url { cwd: '/Users/panva/repo/node' }
⠋ Loading data for nodejs/node/pull/41170
[DEBUG] [fetch] https://raw.githubusercontent.com/nodejs/node/HEAD/README.md

[DEBUG] [fetch] https://api.github.com/graphql

[DEBUG] [fetch] https://api.github.com/graphql

[DEBUG] [fetch] https://api.github.com/graphql

[DEBUG] [fetch] https://api.github.com/graphql
✔  Done loading data for nodejs/node/pull/41170
----------------------------------- PR info ------------------------------------
Title      tls: permit null as a pfx value (#41170)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     CallMeLaNN:fix/pfx-cant-load -> nodejs:master
Labels     tls, author ready, commit-queue-failed
Commits    2
 - tls: permit null as a pfx value
 - tls: permit null as an options value
Committers 1
 - CallMeLaNN <git@lann.me>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41170
Fixes: https://github.com/nodejs/node/issues/36292
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 14 Dec 2021 13:57:39 GMT
   ✔  Approvals: 2
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/41170#pullrequestreview-832783699
   ✔  - Filip Skokan (@panva): https://github.com/nodejs/node/pull/41170#pullrequestreview-832785694
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2021-12-17T09:42:04Z: https://ci.nodejs.org/job/node-test-pull-request/41511/
⠋ Querying data for job/node-test-pull-request/41511/   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
⠴ Querying API for job/node-test-pull-request/41511/

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the git node land command and reproduce the issue using NCU_VERBOSITY=debug git node land 41170. Trace the GitHub GraphQL and Jenkins job queries shown in the logs, especially the point after querying job/node-test-pull-request/41511/. Done means the command completes instead of hanging while processing a pull request.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, javascript, node.js
Domain
ci-cd, cli, devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.