nodejs / nodejs/node-core-utils

Erroneous "Commit message is missing PR-URL" error

Open
#506 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
314
Forks
137
Avg merge
2d 8h
Merged PRs (30d)
24

Description

Seen here: https://github.com/nodejs/node/pull/35405

When i proceed anyway, each message nevertheless has all requisite info:

node on git:v12.x-staging ❯ git rebase upstream/v12.x-staging -i -x "git node land --amend"
Executing: git node land --amend
   ⚠  Found PR-URL: , skipping..
--------------------------------- New Message ----------------------------------
module: named exports for CJS via static analysis

PR-URL: https://github.com/nodejs/node/pull/35249
Backport-PR-URL: https://github.com/nodejs/node/pull/35405
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
--------------------------------------------------------------------------------
? Use this message? Yes
[detached HEAD 65ffce152b] module: named exports for CJS via static analysis
 Author: Guy Bedford <guybedford@gmail.com>
 Date: Thu May 14 22:40:37 2020 -0700
 20 files changed, 1926 insertions(+), 85 deletions(-)
 create mode 100755 deps/cjs-module-lexer/.gitignore
 create mode 100755 deps/cjs-module-lexer/LICENSE
 create mode 100755 deps/cjs-module-lexer/README.md
 create mode 100755 deps/cjs-module-lexer/lexer.js
 create mode 100755 deps/cjs-module-lexer/package.json
 create mode 100644 test/es-module/test-esm-cjs-exports.js
 create mode 100644 test/fixtures/es-modules/cjs-exports.mjs
 create mode 100644 test/fixtures/es-modules/exports-cases.js
 create mode 100644 test/fixtures/es-modules/exports-cases2.js
 create mode 100644 test/fixtures/es-modules/exports-cases3.js
Executing: git node land --amend
   ⚠  Found PR-URL: , skipping..

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported git node land --amend command during the rebase shown in the issue, then trace how it reads the PR-URL from the commit message. The issue provides no file or test path, so locate the relevant CLI entry point and add coverage for a message containing a valid PR-URL. Done means the command no longer reports the PR-URL as missing or empty.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.