[Question] Why are the return values ​​of the two functions different?

Open
#444 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
32/100
Issue type
Documentation
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp, nodejs
Domain
api, documentation

Research direction

Compare the linked myobject.cc sections for 7_factory_wrap and 6_object_wrap, starting with the NewInstance implementation and its use of escape scope. Read the surrounding Node-API example code to determine the intended lifetime behavior, then document why the return paths differ and clarify the examples if needed.

Written by the indexing model from the issue text.

Description

https://github.com/nodejs/node-addon-examples/blob/ed36ba2d8512d73c7171b9537c96a63bc34e9831/src/1-getting-started/7_factory_wrap/node-addon-api/myobject.cc#L24-L28

https://github.com/nodejs/node-addon-examples/blob/ed36ba2d8512d73c7171b9537c96a63bc34e9831/src/1-getting-started/6_object_wrap/node-addon-api/myobject.cc#L46-L58

I'm Newby, who just got into NAPI.
In the above two codes, methods are create and return the object.
I wonder why only the return value in NewInstance uses escape scope.

Dominant language
C++
Stars
2.6k
Forks
602
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nodejs/node-addon-examples

All issues in nodejs/node-addon-examples

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.