'IdleNotificationDeadline' is deprecated: Use MemoryPressureNotification()
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.4k
- Forks
- 531
- Avg merge
- 21m
- Merged PRs (30d)
- 1
Description
Getting the following warning with Node.js 20.x:
../node_modules/nan/nan.h:686:39: warning: 'IdleNotificationDeadline' is deprecated: Use MemoryPressureNotification() to influence the GC schedule. [-Wdeprecated-declarations]
return v8::Isolate::GetCurrent()->IdleNotificationDeadline(
...
This method will be deprecated soon.
https://chromium.googlesource.com/v8/v8/+/refs/heads/main/include/v8-isolate.h#1295
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at nan.h:686, where the warning is reported for Node.js 20.x, and compare the referenced V8 deprecation guidance. Determine the supported replacement and compatibility implications for NAN, then verify that the warning is resolved when building against Node.js 20.x.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- node.js
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100