strings-test.js fails on s390x
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.4k
- Forks
- 531
- Avg merge
- 21m
- Merged PRs (30d)
- 1
Description
We're running into this in Ubuntu's 22.04 CI:
https://autopkgtest.ubuntu.com/results/autopkgtest-jammy/jammy/s390x/n/node-nan/20220306_113841_a17b2@/log.gz
534 passing (12s)
1 failing
-
test/js/strings-test.js FromV8String should be equal:
Error: should be equal
- expected - actual
-栀攀氀氀漀
+helloat Test. (test/js/strings-test.js:36:5)
at Object. (test/js/strings-test.js:14:1)
I wonder if this might be an endian issue with the usage of the Buffer class? We can disable the test but a fix/workaround would be most appreciated.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with test/js/strings-test.js, especially the failing FromV8String assertion at line 36, and reproduce the test in the s390x Ubuntu CI environment described in the issue. Inspect the string and Buffer handling involved in that test. Done means the test passes on s390x while the existing 534 passing tests continue to pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, javascript, node.js
- Domain
- backend, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100