nodejs / nodejs/nan

NewInstance memory leak

Open
#894 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
3.4k
Forks
531
Avg merge
21m
Merged PRs (30d)
1

Description

Nan::HandleScope scope;
Local FunctionTemplate tp = Nan::New(New);
tp->SetClassName(Nan::New(ClassName).ToLocalChecked());
tp->InstanceTemplate()->SetInternalFieldCount(1);
Local Function cons = tp->GetFunction();
Local Object js;
js= Nan::NewInstance(cons, argc, argv).ToLocalChecked();
args.GetReturnValue().Set(js);

Using this method, two are generated( name is ClassName)
Causing a memory leak

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported C++ snippet using Nan::NewInstance and inspect the resulting constructor instances and memory behavior. Done means the snippet no longer creates duplicate constructors or leaks memory; the issue does not name a source file or test to run.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, node.js
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.