AsyncProgress(Queue)Worker progress class requires default constructor
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.4k
- Forks
- 531
- Avg merge
- 21m
- Merged PRs (30d)
- 1
Description
Hi,
Due to the following line:
T *new_data = new T[count];
in the AsyncProgress(Queue)Worker class T (your progress class) is required to have a default constructor.
I have prepared a patch which makes use of C++17 (std::aligned_alloc and std::uninitialized_copy) features and removes the necessity of the progress struct having a default constructor.
Should I wrap the patch in a feature guard (__cplusplus macro check) and file a merge request?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the AsyncProgress(Queue)Worker allocation using new T[count]. Review the proposed C++17 allocation and construction approach, including compatibility with supported compilers. Done means progress types no longer require a default constructor without breaking existing users or supported language versions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100