v2.13.0 broke electron-rebuild
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.4k
- Forks
- 531
- Avg merge
- 21m
- Merged PRs (30d)
- 1
Description
Latest release has broken our build process.
node -v v8.15.0
node-gyp -v v3.8.0
An unhandled error occurred inside electron-rebuild
Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
addon.cc
win_delay_load_hook.cc
c:\projects\emerald-wallet\packages\desktop\node_modules\nan\nan_converters_43_inl.h(60): error C2664: 'bool v8::Value::BooleanValue(void) const': cannot convert argument 1 from 'v8::Isolate *' to 'v8::Local<v8::Context>' (compiling source file ..\src\addon.cc) [C:\projects\emerald-wallet\packages\desktop\node_modules\keccak\build\keccak.vcxproj]
c:\projects\emerald-wallet\packages\desktop\node_modules\nan\nan_converters_43_inl.h(60): note: No constructor could take the source type, or constructor overload resolution was ambiguous (compiling source file ..\src\addon.cc)
gyp ERR! build error
gyp ERR! stack Error: `msbuild` failed with exit code: 1
gyp ERR! stack at ChildProcess.onExit (C:\projects\emerald-wallet\packages\desktop\node_modules\node-gyp\lib\build.js:262:23)
gyp ERR! stack at emitTwo (events.js:126:13)
gyp ERR! stack at ChildProcess.emit (events.js:214:7)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)
gyp ERR! System Windows_NT 6.3.9600
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\projects\\emerald-wallet\\packages\\desktop\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--target=4.0.5" "--arch=x64" "--dist-url=https://atom.io/download/electron" "--build-from-source"
gyp ERR! cwd C:\projects\emerald-wallet\packages\desktop\node_modules\keccak
gyp ERR! node -v v8.15.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
Failed with exit code: 1
Error: Building the projects in this solution one at a time. To enable parallel build, please add the "/m" switch.
addon.cc
win_delay_load_hook.cc
c:\projects\emerald-wallet\packages\desktop\node_modules\nan\nan_converters_43_inl.h(60): error C2664: 'bool v8::Value::BooleanValue(void) const': cannot convert argument 1 from 'v8::Isolate *' to 'v8::Local<v8::Context>' (compiling source file ..\src\addon.cc) [C:\projects\emerald-wallet\packages\desktop\node_modules\keccak\build\keccak.vcxproj]
c:\projects\emerald-wallet\packages\desktop\node_modules\nan\nan_converters_43_inl.h(60): note: No constructor could take the source type, or constructor overload resolution was ambiguous (compiling source file ..\src\addon.cc)
gyp ERR! build error
gyp ERR! stack Error: `msbuild` failed with exit code: 1
gyp ERR! stack at ChildProcess.onExit (C:\projects\emerald-wallet\packages\desktop\node_modules\node-gyp\lib\build.js:262:23)
gyp ERR! stack at emitTwo (events.js:126:13)
gyp ERR! stack at ChildProcess.emit (events.js:214:7)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:198:12)
gyp ERR! System Windows_NT 6.3.9600
gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "C:\\projects\\emerald-wallet\\packages\\desktop\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--target=4.0.5" "--arch=x64" "--dist-url=https://atom.io/download/electron" "--build-from-source"
gyp ERR! cwd C:\projects\emerald-wallet\packages\desktop\node_modules\keccak
gyp ERR! node -v v8.15.0
gyp ERR! node-gyp -v v3.8.0
gyp ERR! not ok
On Windows - https://ci.appveyor.com/project/etcdevteam/emerald-wallet/builds/23066344
On Mac OSX - https://circleci.com/gh/ETCDEVTeam/emerald-wallet/884?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
Thank you for assistance.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the electron-rebuild command and the keccak build output, especially nan/nan_converters_43_inl.h line 60 and the Electron 4.0.5 target. Reproduce the failure using the reported Node, node-gyp, Windows, and macOS CI details; done means the native build completes successfully on the affected platforms.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, electron, nodejs
- Domain
- build-system, devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100