Nan 2.10.0 causing errors
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.4k
- Forks
- 531
- Avg merge
- 21m
- Merged PRs (30d)
- 1
Description
It appears the native addon Node Sass compiled for Node 9 with Nan 2.10.0 are resulting in errors.
i.e.
[1] 9331 illegal hardware instruction npm test
There is more detailed information in https://github.com/sass/node-sass/issues/2293
This may be related the the MakeCallback deprecation. We're happy to address the deprecation within Node Sass, but the I suspect these failure were unexpected.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the linked node-sass issue and reproducing the failure with npm test under Node 9 and Nan 2.10.0. Trace the native addon failure and the suspected MakeCallback deprecation; done means the reported illegal hardware instruction no longer occurs and relevant tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, node.js
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100