async_hooks in node 8
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.4k
- Forks
- 531
- Avg merge
- 21m
- Merged PRs (30d)
- 1
Description
There were major changes to async_hooks between 8.5.0 and 8.6.0.
The same setup that works on 8.6.0 and above results in the following assertion on 8.5.0:
../src/node.cc:1379:v8::MaybeLocal<v8::Value> node::MakeCallback(node::Environment*, v8::Local<v8::Value>, v8::Local<v8::Function>, int, v8::Local<v8::Value>*, node::async_context): Assertion '(env->current_async_id()) == (asyncContext.async_id)' failed.
Until this is resolved, async_hooks will remain disabled for all of Node 8. See #738.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the reported assertion in node.cc:1379 and compare the async_hooks behavior between Node 8.5.0 and 8.6.0. Read the discussion in #738 and the five comments on this issue to determine the intended compatibility fix. Done means the same setup no longer asserts on Node 8.5.0, with coverage for the affected versions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, nodejs
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100