Make symbols work with NAN_PROPERTY_GETTER
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.4k
- Forks
- 531
- Avg merge
- 21m
- Merged PRs (30d)
- 1
Description
Would it be possible to add a macro to have GenericNamedPropertyGetterCallback redirect to NamedPropertyGetterCallback so it doesn't throw an error when looking up a property with a symbol?
nodejs/node#15000
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating NAN_PROPERTY_GETTER and the GenericNamedPropertyGetterCallback and NamedPropertyGetterCallback definitions in the NAN source. Trace how symbol property lookups reach these callbacks; done means the requested macro path no longer throws an error for symbol properties.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, node.js
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100