ExecutionProgress::SendProgress_ overwrites previous values
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.4k
- Forks
- 531
- Avg merge
- 21m
- Merged PRs (30d)
- 1
Description
When ExecutionProgress::Send() is invoked quickly to deliver data on repeated callbacks the previous data values are overwritten by the code line below. This results in only the latest data being delivered via a callback to JavaScript.
https://github.com/nodejs/nan/blob/137bd5ae2d47064d44791a094582d97ca0e1b8bb/nan.h#L1683
It was not clear to me if this is the design of the AsyncProgressWorker or not? I didn't expect it. Also, do you guys have an IRC channel?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at nan.h line 1683 and trace ExecutionProgress::SendProgress_ through AsyncProgressWorker. Reproduce repeated Send() calls from callbacks and inspect how pending data is stored and delivered to JavaScript. Done means the intended behavior is established and the reported overwriting of earlier values is addressed or clearly documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, node.js
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100