The path string returned when nan is imported in node 6 is wrong in some cases
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.4k
- Forks
- 531
- Avg merge
- 21m
- Merged PRs (30d)
- 1
Description
With the method relative('.', __dirname) in include_dirs.js the path isn't got properly when the parent path is in a shared resource (a link to a network resource in the case of windows):
vboxsrv\vagrant\NODE_MODULES\nan (which doesn't exists)
To reproduce this behavior, run the include_dirs.js with node 6 inside of a shared folder of virtualbox, or in a network resource linked to a drive letter.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with include_dirs.js and inspect how relative('.', __dirname) builds the returned path. Reproduce it with Node 6 inside a VirtualBox shared folder or a network resource mapped to a drive letter. Done means the path returned for nan resolves to the actual module directory rather than the malformed path shown in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- node.js
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100