Some exported symbols should stay hidden ?
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.9k
- Forks
- 237
- PR merge metrics
- No merged PRs in 30d
Description
When building a shared libllhttp library (using cmake), the list of exported symbols (attached)
contains a lot of llhttp__internal__c* symbols.
I suppose these should not be exported, i.e. be protected or with visiblity attribute set.
llparse probably needs to support this too.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the CMake shared-library configuration and the attached exported-symbol list, then trace how llhttp__internal__c* symbols are exposed. Check the corresponding llparse support as well. Done means internal symbols are no longer exported or are protected in the shared library, with the generated export list confirming the change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, cmake
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100