nodejs / nodejs/import-in-the-middle
handle non-identifier exports
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 170
- Forks
- 58
- Avg merge
- 3d 19h
- Merged PRs (30d)
- 7
Description
Due to WASM and https://github.com/bmeck/proposal-arbitrary-module-namespace-identifiers JS can export names that are not identifiers, this generally only affects WASM though
See potential fix by using index rather than name like in https://github.com/nodejs/node/blob/255b1db9320df7b2e17a248ba4ab659d3f25853d/test/fixtures/es-module-loaders/mock-loader.mjs#L232
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the export-handling entry point in import-in-the-middle and compare it with Node's test/fixtures/es-module-loaders/mock-loader.mjs around line 232. Reproduce the issue with a WASM module exporting a non-identifier name, then verify that such exports are handled successfully without breaking identifier exports.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, wasm
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100