nodejs / nodejs/gyp-next

Fix MSVS Bug

Open
#9 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
155
Forks
101
Avg merge
6d 2h
Merged PRs (30d)
4

Description

From nodejs/node/tools/gyp_node.py:

On msvs it will crash if it gets an absolute path.
On Mac/make it will crash if it doesn't get an absolute path.

/cc @cclauss @targos any idea about this one?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with nodejs/node/tools/gyp_node.py and investigate the path handling described for MSVS and Mac/make. Reproduce the absolute-path and non-absolute-path cases, then verify that the relevant platform behavior no longer crashes in either environment.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.