nodejs / nodejs/gyp-next

Expansions not working for `'includes'` list items?

Open
#130 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
155
Forks
101
Avg merge
6d 2h
Merged PRs (30d)
4

Description

I noticed if I try any kind of expansion (e.g. command or variable) in 'includes' list items, they don't get expanded or replaced but gyp instead tries to use them literally.

Am I doing something wrong, is this intentional, or is it a bug?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the reported behavior with a minimal gyp input using an expansion in an 'includes' list item. Trace the expansion handling and existing tests, then determine the intended behavior and add coverage showing that the issue is resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.