nodejs / nodejs/corepack

Remove undici dependency when minimum supported Node.js version is 22.3.0

Open
#516 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
3.8k
Forks
279
Avg merge
1h 47m
Merged PRs (30d)
2

Description

It seems like the only reason undici is our dependency is to support proxy env variables. Direct support for these env variables (NO_PROXY, HTTP_PROXY...) has been implemented in undici in https://github.com/nodejs/undici/pull/2994 and released in version v6.14.0 (https://github.com/nodejs/undici/pull/3147). undici has been updated to version beyond 6.14.0 in Node.js v22.3.0 (https://github.com/nodejs/node/pull/53379). So, once minimum supported Node.js version is 22.3.0, we can remove all custom proxy logic and rely on global fetch entirely.

In the meantime, we could drop custom proxy logic and proxy-from-env dependency, provided that we DON'T use global fetch -but the one imported from undici, which is >6.14.0.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

In the Corepack repository, locate the custom proxy handling, proxy-from-env dependency, and fetch entry points described in the issue. Check the minimum supported Node.js version and the undici version available there; done means the unnecessary proxy logic and dependency are removed while proxy environment variables continue to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
developer-experience, tooling
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.