mkshims assumes Node is globally installed
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 3.8k
- Forks
- 279
- Avg merge
- 1h 47m
- Merged PRs (30d)
- 2
Description
The shebang line in the shims created by mkshims is #!/usr/bin/env node. This is broken in at least two ways:
- If some version of node is globally installed (i.e. on PATH), the shim will execute using that node, even if it's not the same node that's in the same directory as the shim.
- If no version of node is globally installed, the shim just fails entirely.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating mkshims and the code that creates the generated shebangs. Reproduce the behavior with Node absent and with a different Node version earlier on PATH. Done means generated shims use the Node installation beside the shim rather than relying on a global executable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- nodejs, typescript
- Domain
- cli, tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100