nodejs / nodejs/core-validate-commit
Invalid Commit Message
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 55
- Forks
- 62
- Avg merge
- 4d 9h
- Merged PRs (30d)
- 1
Description
This PR was merged with a non-imperative verb starting the commit message: benchmark: added new benchmarks for blob.
From what the docs says, it should be a invalid message.
The CI did raised an error about the length (that I fix) but didn't raise an error about this verb and it was merged.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the commit-message guidelines and the validation exercised by PR 49730, then trace the check that reported the message-length error. Verify how the commit subject’s opening verb is evaluated. Done means a non-imperative subject such as “added new benchmarks for blob” is rejected by CI while valid imperative wording passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- ci-cd, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100