nodejs / nodejs/citgm

multer@v1.4.5-lts.1 failures

Open
#999 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
606
Forks
157
Avg merge
3d 23h
Merged PRs (30d)
3

Description

Hi @linusu I noticed you're listed as maintainer for multer so I'd like to bring to your attention that multer@v1.4.5-lts.1 tests have been failing inconsistently across different systems on v18.x. Feel free to loop in more contributors that you think may help.

I can reproduce the test issue on my macOS with node v18.18.0.
On this pastebin you can clearly see that the first run generates an error but the second one works fine without any config change.

To temporary address this issue, I created #998 to set the test flaky on macOS but would be great to fix the underlying issue (if present)

Here are a few failed citgm runs for reference:
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3298/testReport/

As you can see on this run multer is failing on three different nodes. Right now I'm not able to test on other architectures, but can be that the module is flaky also on these platforms

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked citgm-smoker test report and reproduce the intermittent failure on macOS with Node v18.18.0, comparing the first and second runs described in the issue and the pastebin output. Check the temporary workaround in #998; done means identifying and fixing the underlying flaky test behavior and confirming the relevant citgm runs pass consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.