nodejs / nodejs/citgm

Re-enable node-sass

Open
#832 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
606
Forks
157
Avg merge
3d 23h
Merged PRs (30d)
3

Description

Possible regression missed in 14.6 https://github.com/nodejs/node/issues/35365, and was disabled in https://github.com/nodejs/citgm/pull/790

We're looking at disabling the larger spec-suite tests that might have been why it got marked as flakey before

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the node-sass regression in nodejs/node#35365 and the disabling change in citgm#790 first. Then inspect the larger spec-suite tests mentioned in the issue and determine whether re-enabling node-sass leaves those tests stable; done means node-sass is enabled without the reported flakiness.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, nodejs
Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.