nodejs / nodejs/citgm

mark vinyl-fs as non-flaky

Open
#444 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
606
Forks
157
Avg merge
3d 23h
Merged PRs (30d)
3

Description

We recently discovered a regression on streams (https://github.com/nodejs/node/pull/13850) in the 8 line (and readable-stream 2.3.1), that we would have caught if this module was added.

What can we do to mark it as non-flaky anymore?

cc @phated

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how CITGM records flaky and non-flaky modules, then review the linked Node.js streams regression and the readable-stream 2.3.1 context. Done means vinyl-fs is treated as non-flaky and its relevant test runs reliably without reproducing the reported regression.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
testing-qa
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.