nodejs / nodejs/citgm

Proposal: Lock module version in lookup.json

Open
#407 24 comments 2 reactions 1 assignee View on GitHub

@gibfahn is already working on this.

Since Oct 26, 2017.

Dominant language
JavaScript
Stars
606
Forks
157
Avg merge
3d 23h
Merged PRs (30d)
3

Description

As we test more modules in CitGM, triaging failures does not seem to be scaling.

With any failure we need to work out whether it was caused by:

  • the change in Node we're testing
  • the module/module test suite being updated
  • flaky tests

To make life easier I would suggest that we:

  • Lock the modules to specific (known working) versions in the lookup.json (with appropriate flaky tags if necessary).
  • Allow module authors to raise PRs to update the versions (when they feel like it). We can update modules ourselves in batches too (perhaps at weekly or monthly intervals).

This means that instead of constantly having to stay on top of all of the module/modules test suite updates and regularly having to mark some of these tests as flaky, we could do this in batches at a regular interval.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.