nodejs / nodejs/build

Benchmark machines doesn't compare against v22.x

Open
#3,866 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jinja
Stars
541
Forks
185
Avg merge
22h 15m
Merged PRs (30d)
4

Description

Hey folks,

We are trying to run benchmarks for https://github.com/nodejs/node/pull/54452 but it's constantly failing. I suspect it's because benchmark machines don't have the v22.x branch reference.

The errors look like deps/amaro aren't fetched correctly, but the reason might be an outdated version of the code. See: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1611/consoleText

error: test/es-module/test-typescript-transform.mjs: does not exist in index

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the benchmark-node-micro-benchmarks/1611 console output and inspect the build configuration that supplies branch references for benchmark machines. Check the deps/amaro checkout failure and whether v22.x is available; done means the benchmark compares against v22.x and fetches test/es-module/test-typescript-transform.mjs successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, nodejs
Domain
ci-cd, devops, performance
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.