nodejs / nodejs/build

Don't build/serve website from NGINX

Open
#3,636 4 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jinja
Stars
541
Forks
185
Avg merge
22h 15m
Merged PRs (30d)
4

Description

The website is now served from Vercel, so it is redundant to serve it from NGINX as well. It has also been observed that the version from NGINX that is available at origin.nodejs.org is being indexed in Google, so removing it should resolve this.

It should be called out that the dist, download, docs, api, etc. should still be served from NGINX.

The site build script can be removed, as well as various parts of the NGINX config relating to the serving of Next.js:

https://github.com/nodejs/build/blob/0a0ed87552b37eef80edc5e82409e311351cb8e8/ansible/www-standalone/resources/config/nodejs.org?plain=1#L114-L117

https://github.com/nodejs/build/blob/0a0ed87552b37eef80edc5e82409e311351cb8e8/ansible/www-standalone/resources/config/nodejs.org?plain=1#L124-L172

https://github.com/nodejs/build/blob/0a0ed87552b37eef80edc5e82409e311351cb8e8/ansible/www-standalone/resources/config/nodejs.org?plain=1#L264-L292

https://github.com/nodejs/build/blob/0a0ed87552b37eef80edc5e82409e311351cb8e8/ansible/www-standalone/tasks/site-setup.yaml#L92

https://github.com/nodejs/build/blob/0a0ed87552b37eef80edc5e82409e311351cb8e8/ansible/www-standalone/tasks/site-setup.yaml#L102

https://github.com/nodejs/build/blob/0a0ed87552b37eef80edc5e82409e311351cb8e8/ansible/www-standalone/resources/scripts/check-build-site.sh#L5-L6

https://github.com/nodejs/build/blob/0a0ed87552b37eef80edc5e82409e311351cb8e8/ansible/www-standalone/resources/scripts/build-site.sh#L7-L8

https://github.com/nodejs/build/blob/0a0ed87552b37eef80edc5e82409e311351cb8e8/ansible/www-standalone/resources/scripts/build-site.sh#L23-L26

I'm probably missing some other bits.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the referenced nodejs.org NGINX configuration and the site-setup.yaml, check-build-site.sh, and build-site.sh files. Confirm which Next.js build and serving steps can be removed while preserving NGINX serving for dist, download, docs, and api; done means the obsolete website path and its build checks are gone without affecting those paths.

Written by the indexing model from the issue text.

Assessment

Tech stack
ansible, nginx
Domain
devops, infrastructure
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.