nodejs / nodejs/build

Can we copy artefacts for the fanned Windows jobs instead of a private git repo?

Open
#3,465 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jinja
Stars
541
Forks
185
Avg merge
22h 15m
Merged PRs (30d)
4

Description

As part of diagnosing a disk space issue on the CI server it was brought to my attention that we're using a private git repository hosted on one of our servers for copying the binary output between the windows compilation and test jobs.

This feels to me like unnecessary complexity and I'm wondering whether it would make sense to use the jenkins artefact from the compile job and pull from that directlry into the test jobs instead of going via that git repository. My understanding is that we were doing the same for the arm32 fanned jobs before we switched them over to using the aarch64 hosted systems for those (since there was no reason to fan them in that situation)

Since I'm not aware of the history of why we chose to use a git repo for the binaries, does anyone have the history of the reasoning, or is there a good reason not to consider using the standard jenkins artefact process instead? @joaocgreis @nodejs/build

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the linked Windows compilation and test jobs, focusing on how binary output moves through the private git repository and Jenkins artifacts. Check the issue discussion for the historical reason for the current flow; done means reaching a documented decision on whether Jenkins artifacts can replace the repository and, if approved, completing that migration.

Written by the indexing model from the issue text.

Assessment

Domain
ci-cd, infrastructure
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.