Treating groups of commits as one unit
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 52
- Forks
- 21
- PR merge metrics
- No merged PRs in 30d
Description
In https://github.com/nodejs/node/pull/10886 I noticed that at least for one particular PR, all but 1 of its commits were being included. I think it would be a good idea to first group commits by PR and then check that all of the commits from a particular PR are landable. If all of them aren't, then none of the commits should be included.
I think such a behavior should be default, but at the very least a command line option would be okay I suppose.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the branch-diff command entry point and the current logic that selects commits from one branch but not another. Use the behavior described in nodejs/node/pull/10886 as the motivating case. Done means commits are grouped by pull request, and a group is included only when all of its commits are landable, with the default behavior or a command-line option clearly defined.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, javascript
- Domain
- cli, tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100