DiffFile not reporting correct file size
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 5.8k
- Forks
- 704
- PR merge metrics
- No merged PRs in 30d
Description
System information
- node version: 10.11.0
- npm or yarn version: yarn v1.12.3
- OS/version/architecture: darwin 18.2.0 x64
- Applicable nodegit version: 0.23.0-alpha.1
When I call .size() on a DiffFile object 0 is always returned rather than the files actual size.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the DiffFile.size() entry point described in the report and reproduce the result with nodegit 0.23.0-alpha.1 on a sample diff. Trace how the DiffFile obtains its size, then verify that size() returns the actual file size rather than 0.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, javascript, node.js
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100