nodeSolidServer / nodeSolidServer/node-solid-server

Missing content escape when globbing

Open
#923 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
JavaScript
Stars
1.8k
Forks
308
PR merge metrics
No merged PRs in 30d

Description

I have created a resource at /items/<A>AA-123. If I look up /items/ the data browser works as expected and shows it as <A>AA-123 everywhere.

But if I look up /items/* I get an incorrectly formatted RDF document:

@prefix : <#>.
@prefix terms: <http://purl.org/dc/terms/>.
@prefix sol: <http://elfisk.dk/ns/solidrc#>.
@prefix XML: <http://www.w3.org/2001/XMLSchema#>.
@prefix c: </profile/card#>.
@prefix mod: <./>.

<<A>AA-123>
    a sol:model;
    terms:created "2018-11-09T09:26:32Z"^^XML:dateTime;
    terms:creator c:me;
    terms:title "<S>AAA".

Apparently the "globbing handler" failed to encode the content correctly.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue by comparing /items/ with /items/* and inspect the globbing handler responsible for generating the RDF response. Trace how the resource name and title are serialized, then verify that angle brackets and other content are escaped correctly in the generated RDF document.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, nodejs
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.