nodeSolidServer / nodeSolidServer/node-solid-server
Exclude swap files (.swp) from containment statements
Nobody has claimed this yet.
- #1760 by @bourgeoa — closed without merging
- Dominant language
- JavaScript
- Stars
- 1.8k
- Forks
- 308
- PR merge metrics
- No merged PRs in 30d
Description
https://fileinfo.com/extension/swp
.swp file is created when a text editor like nano or vim opens a file in a directory. When the editor is closed, the swap file is removed.
While swap files exist in a directory, NSS includes them in containment statements.
My attempts to GET the .swp file resulted in a 404, but this could still be a potential risk. At the very least, it does expose information when it really shouldn't.
I suggest excluding .swp from containment statements.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names containment statements and .swp files but no implementation files or tests. Start by locating the code that generates containment statements and reproduce the behavior with a temporary .swp file. Done means .swp files are excluded from containment statements without breaking other file handling, with relevant tests passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- backend, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100