nodeSolidServer / nodeSolidServer/node-solid-server

Uploading files does not always respect "extensions" in Slug

Open
#1,612 21 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.8k
Forks
308
PR merge metrics
No merged PRs in 30d

Description

I'm trying to upload an jpeg image file. In the Slug header I give it a name with a .jpg extension. However, the server appends another extension after that-- .jpeg.

Screen Shot 2021-08-22 at 12 41 27 AM

Is there some way I can get it to stop appending the additional extension? I really need to be able to supply my own extensions in my own application.

Thanks!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no file or test; start by locating the upload path that processes the Slug header and compare the supplied .jpg name with the server's appended .jpeg extension. Done means establishing and implementing the intended behavior for user-supplied extensions, with tests covering this upload case.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.