nodeSolidServer / nodeSolidServer/node-solid-server

Incorrect `iss` value on tokens, not the same as `issuer` value in OpenID configuration

Open
#1,609 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

authentication blocker bug
Dominant language
JavaScript
Stars
1.8k
Forks
308
PR merge metrics
No merged PRs in 30d

Description

When trying to log in to CSS using the run-against-css.sh script of the WAC tests, you get:

2021-08-11T12:45:33.820Z [DPoPWebIdExtractor] warn: Error verifying WebID via DPoP-bound access token: The access token issuer doesn't match its associated WebID's trusted OIDC issuers.
Actual: https://solidcommunity.net/
Expected: https://solidcommunity.net

So maybe we can change NSS to remove that trailing slash from the issuer?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the mismatch with the WAC tests' run-against-css.sh entry point and inspect the DPoPWebIdExtractor path that verifies the token issuer against trusted OpenID issuers. Trace where NSS produces or reads the issuer value; done when the token and configuration values agree and the CSS login no longer reports an issuer mismatch.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
authentication
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.