nodeSolidServer / nodeSolidServer/node-solid-server
Get automatically re-logged-in without
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.8k
- Forks
- 308
- PR merge metrics
- No merged PRs in 30d
Description
I have a problem with loggin in to NSS that it assumes which user I want to be instead of waiting for me to type it in. For example whenever I log in with inrupt.net it logs me in as timblBOT.inrupt.net not timbl.
@jaxoncreed Not sure where to report that. I guess it is a problem with the current auth code which noone is working on, presumably — though who knows it may carry through to the next version too.
Tim Berners-Lee: Yes @RubenVerborgh it looks like a cookie problem that it sees the cookie and just grabs it. But if I explicitly log out it should delete the cookie surely
Ruben Verborgh: Indeed, that is what NSS should do.
Tim Berners-Lee @timbl 13:06
Suppose I try delete cookies > log out > … weird the log out button doesn’t do anything.
well not surprising it should break solidos as I didn’t tell it I logged out by myself.
But I can reload the page which then takes me to a logged out state, then I can go log in > select inrupt -> then I have a choice of user. So the problem seems to be that NSS doesn’t delete all Local Storage and Cookies on logout?
I’ll file it as an NSS bug then.
I suggest it is good to delete ALL local storage and ALL cookies for the domain partly form privacy and partly to help move on to the next version of the auth protocol which may format these things differently.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names only the authentication code and logout button, not specific files or tests. Start by tracing the logout flow and checking how cookies and local storage are handled; done should mean logging out clears the relevant state so the next login can select a different user.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100