nodeSolidServer / nodeSolidServer/node-solid-server

Make nodemailer secure setting configurable

Open
#1,123 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
1.8k
Forks
308
PR merge metrics
No merged PRs in 30d

Description

Currently the nodemailer secure setting is not configurable via command line:

https://github.com/solid/node-solid-server/blob/3d082f1c2b8cd8e8b0374b369966e723f6ec6bd4/bin/lib/init.js#L70

and

https://github.com/solid/node-solid-server/blob/3d082f1c2b8cd8e8b0374b369966e723f6ec6bd4/bin/lib/start.js#L48

true might be a good setting for port 465, but for the actually should-be used port 587 the setting should be false: http://nodemailer.com/smtp/ . Else this error appears:

https://forum.solidproject.org/t/debugging-email-sending/1375

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the nodemailer setup in bin/lib/init.js around line 70 and bin/lib/start.js around line 48, then trace how command-line options are parsed. Make the nodemailer secure setting configurable through the command line while preserving the intended behavior for the documented SMTP ports, and verify the option in the relevant startup path.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
cli
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.